Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assertion failure for swipe typing and undo on Android #1898

Merged
merged 1 commit into from
May 28, 2024

Conversation

crasowas
Copy link
Contributor

Description

This PR fixes issue #1884.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@singerdmx singerdmx merged commit 189713b into singerdmx:master May 28, 2024
2 checks passed
@singerdmx
Copy link
Owner

this fix seems to be a fix for iOS as well

@crasowas
Copy link
Contributor Author

this fix seems to be a fix for iOS as well

I didn't encounter this issue when testing on iOS, which might be because of differences in IMEs across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion fails for swipe typing + Undo (Android)
2 participants