Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search dialog throw an exception due to missing FlutterQuillLocalizations.delegate in the editor #1938

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

EchoEllet
Copy link
Collaborator

Description

When using the shortcut for showing the search dialog in the editor, you will get an exception due to missing FlutterQuillLocalizations.delegate.

Related Issues

it also seems that the option for SearchButtonType in:

QuillToolbar.simple(
    configurations: QuillSimpleToolbarConfigurations(
      searchButtonType: SearchButtonType.legacy,
    ),
  )

Will be ignored when showing the search dialog using a shortcut and will always use QuillToolbarSearchDialog.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@EchoEllet EchoEllet merged commit 26b0444 into master Jun 21, 2024
2 checks passed
@EchoEllet EchoEllet deleted the fix/search-dialog-shortcut branch June 29, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant