Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Can't select file #52

Closed
IAmDarush opened this issue May 17, 2017 · 7 comments
Closed

Can't select file #52

IAmDarush opened this issue May 17, 2017 · 7 comments

Comments

@IAmDarush
Copy link

In the files listview, clicking on a directory will open the directory, but clicking on a file does nothing unless you click on the checkbox next to file. This makes user experience very inconvenient.

Is there any work-around to this or could you please fix this?

@singhangadin
Copy link
Owner

singhangadin commented May 17, 2017

It does, I added it here

@IAmDarush
Copy link
Author

Thank you bro it was my bad. I was using compile 'com.github.angads25:filepicker:1.0.6' version; I changed it to com.github.angads25:filepicker:1.1.0.

It works perfectly fine on MULTI_MODE, but when I use the SINGLE_MODE to select a single file, sometimes it does not select a file properly and I have to press it twice to be selected. If you can, go to a directory with multiple files, then select a file then select another file and then again select the previous file, you will see that it won't be select unless you try to press on it again.

TL;DR: using SINGLE_MODE one has to press a file twice to selected after being selected once. Could this be because of a Checkbox's behavior?

@singhangadin
Copy link
Owner

singhangadin commented May 18, 2017

I think it's checkbox's behaviour that makes it odd. I have tried on my device and it is working fine.

@IAmDarush
Copy link
Author

Thanks. I think if Checkbox was changed to RadioButton in SINGLE_MODE it would not give the problem.

@singhangadin
Copy link
Owner

I have been getting a lot of issues regarding odd behavior of checkbox upon clicks, Soon or later I will come up with a new alternative to it.

@singhangadin
Copy link
Owner

Hi, I have made few major changes for checkbox click issue. Will really appreciate if you could see to that and help me with bugs. Thank you.

singhangadin pushed a commit that referenced this issue May 19, 2017
…ble click issues.

Stock Checkbox was having issues in selection of a row. Sometimes it works, sometimes it doesn't. As I fix to that, I made a custom checkbox from scratch. Though it might have few theming issues in the beginning but I believe there won't be any functionality issues in that.

Resolves: #25 #45 #52
@IAmDarush
Copy link
Author

Thanks bro. So far very good. That is appreciable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants