Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "external_links" (array of URLs) rather than "external_tickets" #23

Merged
merged 1 commit into from
May 31, 2021
Merged

Use "external_links" (array of URLs) rather than "external_tickets" #23

merged 1 commit into from
May 31, 2021

Conversation

etipton
Copy link
Contributor

@etipton etipton commented May 27, 2021

Addresses: #22

(untested) tested.

@etipton
Copy link
Contributor Author

etipton commented May 27, 2021

This "worked" but note that it created an "external link" like:

image

rather than adding something under the "Pull Requests" section like:

image

(which is still better than nothing IMO)

@etipton etipton marked this pull request as ready for review May 27, 2021 22:10
@singingwolfboy
Copy link
Owner

Looks good to me! I haven't tested this myself, but I've verified that the Clubhouse API documentation supports this change. If you say you've tested it, that's good enough for me!

@singingwolfboy singingwolfboy merged commit 741f078 into singingwolfboy:main May 31, 2021
@etipton
Copy link
Contributor Author

etipton commented Jun 7, 2021

Looks good to me! I haven't tested this myself, but I've verified that the Clubhouse API documentation supports this change. If you say you've tested it, that's good enough for me!

Have been on vaca so just noticed this. Thanks!

@jerm
Copy link

jerm commented Jul 6, 2021

This was vexing me as well. Just as i finally got around to investigating, i saw your fix and upgraded. Thanks! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants