Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask-dance 6.0.0 incompatable with Flask >=2.2.0 #396

Closed
rez10191 opened this issue Aug 2, 2022 · 2 comments
Closed

flask-dance 6.0.0 incompatable with Flask >=2.2.0 #396

rez10191 opened this issue Aug 2, 2022 · 2 comments

Comments

@rez10191
Copy link

rez10191 commented Aug 2, 2022

Hello,

Flask 2.2.0 was released today. This release included this change list: pallets/flask@0b2f809 which removes the _lookup_app_object function that is imported from flask_dance/contrib/google.py, as well as many other contrib modules by the looks of it. The function was properly marked as a private.

Thanks for your great work on this project!

Richard Zuber
@BlitzJB
Copy link

BlitzJB commented Aug 3, 2022 •
edited
Loading

Faced the same issue! @rez10191 Can you point me in the general direction of a workaround? I could put some time into this and submit a PR!

Edit: #397 Is my fix

@BlitzJB BlitzJB mentioned this issue Aug 3, 2022
Closed
@singingwolfboy singingwolfboy mentioned this issue Aug 4, 2022
Merged
@singingwolfboy
Copy link
Owner

I just released Flask-Dance 6.1.0, which switches to using flask.g for storing information, as recommended by the Flask release notes. Thanks for the heads-up about this change!

@peterb154 peterb154 mentioned this issue Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@singingwolfboy @rez10191 @BlitzJB