Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 #1578

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 #1578

merged 3 commits into from
Aug 4, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 4, 2023 •
edited
Loading

Issue and/or context: #1567

Changes: Micro-bump core and R/Python layers

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -11.24% ⚠️

Comparison is base (74cf876) 64.82% compared to head (195855a) 53.59%.

❗ Current head 195855a differs from pull request most recent head f9d9dbd. Consider uploading reports for the commit f9d9dbd to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1578       +/-   ##
===========================================
- Coverage   64.82%   53.59%   -11.24%     
===========================================
  Files         105       74       -31     
  Lines        8788     6141     -2647     
===========================================
- Hits         5697     3291     -2406     
+ Misses       3091     2850      -241
Flag Coverage Δ
python ?
r 53.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eddelbuettel
eddelbuettel previously requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the change in apis/r/configure to fetch 0.20.3 as needed.

@johnkerl
Copy link
Member Author

johnkerl commented Aug 4, 2023

Please add the change in apis/r/configure to fetch 0.20.3 as needed.
Thanks @eddelbuettel I thought I had, let me double-check

@johnkerl johnkerl changed the title Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 [WIP] Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 Aug 4, 2023
@johnkerl johnkerl marked this pull request as ready for review August 4, 2023 20:25
@johnkerl johnkerl dismissed eddelbuettel’s stale review August 4, 2023 20:44

requested change was mae

eddelbuettel
eddelbuettel approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it, when I checked earlier file configure was not yet in the set.

@johnkerl johnkerl merged commit 9d100df into main Aug 4, 2023
4 checks passed
@johnkerl johnkerl deleted the kerl/use-2.16.2 branch August 4, 2023 21:08
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
@johnkerl @github-actions
Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 (#1578)
e003361 
* Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3

* apis/r/configure

* DESCRIPTION
johnkerl added a commit that referenced this pull request Aug 4, 2023
@github-actions @johnkerl
Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3 (#1578) (#…
79a9bea 
…1579)

* Depend on core 2.16.2, TileDB-Py 0.22.2, and TileDB-R 0.20.3

* apis/r/configure

* DESCRIPTION

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

@aaronwolen aaronwolen aaronwolen approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

@thetorpedodog thetorpedodog Awaiting requested review from thetorpedodog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnkerl @codecov-commenter @eddelbuettel @aaronwolen