Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] No more "Last 13 lines of output:" in CI #1871

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 6, 2023

As discussed in Slack

@eddelbuettel
Copy link
Member

Likely redundant because of https://github.com/single-cell-data/TileDB-SOMA/blob/main/apis/r/tools/r-ci.sh#L42

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 34 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl merged commit 08338c5 into main Nov 6, 2023
12 of 13 checks passed
@johnkerl johnkerl deleted the kerl/r-ci-verbosity branch November 6, 2023 16:15
@johnkerl
Copy link
Member Author

johnkerl commented Nov 6, 2023

I am seeing CI output I didn't see before. This is a good thing.

@eddelbuettel
Copy link
Member

What's the test command? Are you going through r-ci.sh which should have the value, or via R CMD ... directly?

@johnkerl
Copy link
Member Author

johnkerl commented Nov 6, 2023

@eddelbuettel I am seeing more output before in CI logs linked to from these PRs here in GitHub. I am happy with that fact.

@eddelbuettel
Copy link
Member

@johnkerl I am happy you are happy but you did not answer my question to which my curious mind would still love an answer: how did you trigger the tests so that setting YML fixed?

(Longer story R also reflects env variables just for checking from a file ~/.R/check.Renviron, if it exists, so I have been contemplating having the bootstrap step during r-ci.sh run create it. For that more info hence my question.)

@johnkerl
Copy link
Member Author

johnkerl commented Nov 6, 2023

@eddelbuettel I don't know the answer to your question.

  • Before this PR I was seeing "Last 13 lines of output" when clicking through "Checks" links on PRs in this repo
  • After this PR I am seeing more output
  • I changed nothing other than what you see on this PR
  • That is all I know, and all I need to know

@eddelbuettel
Copy link
Member

@johnkerl So you are saying that the test was triggered as before by cd apis/r && tools/r-ci.sh run_tests. I asked you because during the ongoing discussions around the CI fail we had brought the topic of triggering the tests differently (e.g. via a call to R CMD check .... So what this shows then is that r-ci.sh was supposed to already supply the setting but didn't. This gives me more to work with so thanks for all your continued help in finding this.

johnkerl added a commit that referenced this pull request Nov 6, 2023
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants