[WIP] [r] Remove expect_no_condition() calls for write_soma.SingleCellExperiment()
#1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CellExperiment()` For some reason, `write_soma.SingleCellExperiment()` seems to be calling a version of `as.data.frame.numeric()` that throws a deprecation warning. I believe this is causing downstream errors where testthat kills the write, but continues through the test suite. This PR is simply to test this theory
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 34 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
Replaced by #1876 |
johnkerl
pushed a commit
that referenced
this pull request
Nov 6, 2023
…#1878) Bioc 3.18 and R 4.3.2 now throw deprecation warnings when casting from `S4Vectors::DataFrame` to `data.frame`; this PR suppresses deprecation warnings when doing that cast, but allows additional warnings to percolate through [sc-36559] replaces #1874 resolves #1875 Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
write_soma.SingleCellExperiment()seems to be calling a version ofas.data.frame.numeric()that throws a deprecation warning. I believe this is causing downstream errors where testthat kills the write, but continues through the test suite. This PR is simply to test this theory.Tracking issue: #1875.