Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/python] Make Python blockwise tests less resource-intensive #1877

Merged
merged 3 commits into from
Nov 6, 2023
Merged

[ci/python] Make Python blockwise tests less resource-intensive #1877

merged 3 commits into from
Nov 6, 2023

Conversation

bkmartinjr
Copy link
Member

@bkmartinjr bkmartinjr commented Nov 6, 2023 •
edited by johnkerl
Loading

Changes:

  • increase sparsity of test arrays for blockwise iterator unit tests
  • add an explicit soma context to some tests that benefit from a bit more memory in their initial query

Context: #1862

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 72 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@johnkerl johnkerl changed the title make Python blockwise tests less resource intensive [python] Make Python blockwise tests less resource-intensive Nov 6, 2023
@bkmartinjr bkmartinjr marked this pull request as ready for review November 6, 2023 19:43
johnkerl
johnkerl approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bkmartinjr bkmartinjr merged commit 691deb5 into main Nov 6, 2023
29 checks passed
@bkmartinjr bkmartinjr deleted the bkmartinjr/more-sparse-pytest-tuning branch November 6, 2023 19:47
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
@github-actions
[python] Make Python blockwise tests less resource-intensive (#1877)
c094d4c 
* make blockwise tests less resource intensive

* even more test pruning

* lint
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
johnkerl pushed a commit that referenced this pull request Nov 6, 2023
@github-actions
[python] Make Python blockwise tests less resource-intensive (#1877) (#…
e42e5c2 
…1879)

* make blockwise tests less resource intensive

* even more test pruning

* lint

Co-authored-by: Bruce Martin <bruce@chanzuckerberg.com>
@johnkerl johnkerl changed the title [python] Make Python blockwise tests less resource-intensive [ci/python] Make Python blockwise tests less resource-intensive Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkmartinjr @codecov-commenter @johnkerl