Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/ci] Complete 3.8 -> 3.11 work #2278

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[python/ci] Complete 3.8 -> 3.11 work #2278

merged 2 commits into from
Mar 15, 2024

Conversation

johnkerl
Copy link
Member

As surfaced in the nightly smoke test for wheel-install:
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8294234646/job/22699837592

Follow-on/completion from #2267

@johnkerl
Copy link
Member Author

Note for posterity: this was surfaced in a nightly smoke test. To run it sooner I went to the Actions page for this repo, selected the "TileDBSOMA python sdist & wheels CI", and "Run workflow" and the branch name for this PR.

Screenshot 2024-03-15 at 9 34 03 AM

Screenshot 2024-03-15 at 9 34 15 AM

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #2278 (916b9f4) into main (0fcce69) will decrease coverage by 1.47%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   80.28%   78.82%   -1.47%     
==========================================
  Files          87      139      +52     
  Lines        6367    10724    +4357     
  Branches      214      215       +1     
==========================================
+ Hits         5112     8453    +3341     
- Misses       1169     2172    +1003     
- Partials       86       99      +13     
Flag Coverage Δ
libtiledbsoma 67.44% <ø> (+3.45%) ⬆️
python 90.99% <ø> (ø)
r 74.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.99% <ø> (ø)
libtiledbsoma 48.77% <ø> (+0.08%) ⬆️

@johnkerl
Copy link
Member Author

@jdblischak
Copy link
Collaborator

Looks like more mixing of py38 and py311

Setting up libpython3.8-dev:amd64 (3.8.10-0ubuntu1~20.04.9) ...
Setting up python3-pip (20.0.2-5ubuntu1.10) ...
Setting up g++-9 (9.4.0-1ubuntu1~20.04.2) ...
Setting up python3.8-dev (3.8.10-0ubuntu1~20.04.9) ...

# skipping a few lines

ERROR: tiledbsoma-1.5.0rc0.post244.dev566639412-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl is not a supported wheel on this platform.

@johnkerl
Copy link
Member Author

Confirmed:
https://github.com/single-cell-data/TileDB-SOMA/blob/kerl/smoke-test-more/.github/workflows/python-packaging.yml#L147-L156

ubuntu@anzo[prod][][~]$ alias dreb
alias dreb='docker run --rm -it --entrypoint=/bin/bash'

ubuntu@anzo[prod][][~]$ dreb ubuntu:20.04

root@0b6965a860e0:/# apt-get -qq update

root@0b6965a860e0:/# apt-get install -y python3-pip python3-wheel
...

root@0b6965a860e0:/# python3 --version
Python 3.8.10

@johnkerl
Copy link
Member Author

Manual run https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8297954893 successful

@johnkerl johnkerl merged commit a016b9d into main Mar 15, 2024
24 checks passed
@johnkerl johnkerl deleted the kerl/smoke-test-more branch March 15, 2024 15:12
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
* [python/ci] Complete 3.8 -> 3.11 work

* Use a Python 3.11 Docker image for smoke test
johnkerl added a commit that referenced this pull request Mar 15, 2024
* [python/ci] Complete 3.8 -> 3.11 work

* Use a Python 3.11 Docker image for smoke test

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants