Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CSS conflicts breaking UI #65

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Prevent CSS conflicts breaking UI #65

merged 1 commit into from
Mar 22, 2022

Conversation

ralphsaunders
Copy link
Contributor

Renders UI to ShadowDOM elements, preventing external CSS rules interfering with desired import-map UI.

Resolves #63 but also prevents future issues unlike the solution in #64.

@ralphsaunders
Prevent CSS conflicts breaking UI
373d9ee 
Renders UI to ShadowDOM elements, preventing external CSS rules
interferring with desired import-map UI.
joeldenning
joeldenning approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally and it appears to work well. Thanks for the contribution, I was expecting switching to shadow dom to be harder.

@joeldenning joeldenning merged commit 62384b1 into single-spa:main Mar 22, 2022
@joeldenning
Copy link
Member

Released in https://github.com/joeldenning/import-map-overrides/releases/tag/v3.0.0

@nilzona nilzona mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buttons in ui can get "bad" styling
2 participants
@ralphsaunders @joeldenning