Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: setup Cypress for end-to-end testing #156

Merged
merged 6 commits into from Apr 9, 2020
Merged

build: setup Cypress for end-to-end testing #156

merged 6 commits into from Apr 9, 2020

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Apr 6, 2020

@joeldenning

In short what I've done:

  • added integration folder with 2 folders inside:
    • shop (simple Angular application with routing)
    • portal (single-spa web app)
  • added cypress. Added scenario for the "back button" issue when change detection gets broken

What changes will be required further?

  • currently package.json of the NPM package is located in the root folder
    • the root package.json should contain only devDependencies and be private: true
  • NPM package.json should be isolated inside the src folder
  • single-spa-angular/browser-lib should be built with ng-packagr since it emits Angular compatible code that can be proceeded by both view engine and Ivy compilers

@arturovt arturovt marked this pull request as ready for review April 7, 2020 12:52
@joeldenning
Copy link
Member

This is a big one - will try to make time for it today, but it might be tomorrow before I can look at it.

@arturovt arturovt changed the title build: add E2E tests build: setup Cypress for end-to-end testing Apr 7, 2020
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this - this will really help. I have a few initial questions before diving deeper into the specifics.

yarn.lock Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
integration/docker-compose.yml Outdated Show resolved Hide resolved
integration/portal/webpack.config.js Show resolved Hide resolved
cypress/integration/issue-94.js Show resolved Hide resolved
cypress.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@joeldenning
Copy link
Member

Thanks again for all your work on this - I am signing off for the day but will look at this tomorrow morning.

Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for your work on it.

@joeldenning joeldenning merged commit 6eb14dc into single-spa:master Apr 9, 2020
@arturovt arturovt deleted the e2e-tests branch April 9, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants