Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch latest NPM package version except of hardcoding those values #161

Merged
merged 5 commits into from Apr 8, 2020
Merged

feat: fetch latest NPM package version except of hardcoding those values #161

merged 5 commits into from Apr 8, 2020

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Apr 8, 2020

No description provided.

@arturovt arturovt removed the blocked label Apr 8, 2020
joeldenning
joeldenning reviewed Apr 8, 2020
View reviewed changes
src/schematics/ng-add/npm.ts Outdated Show resolved Hide resolved
src/schematics/ng-add/npm.ts Outdated Show resolved Hide resolved
joeldenning
joeldenning reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One last comment

package.json Outdated Show resolved Hide resolved
@joeldenning joeldenning merged commit c7696c5 into single-spa:master Apr 8, 2020
@arturovt arturovt deleted the feat/fetch-latest-version branch April 8, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
ready to release type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arturovt @joeldenning