Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parcel fixes #171

Merged
merged 8 commits into from Apr 18, 2020
Merged

Parcel fixes #171

merged 8 commits into from Apr 18, 2020

Conversation

joeldenning
Copy link
Member

This PR fixes the broken build for the parcel component. Right now parcel is compiled separately with typescript instead of ng-packagr, perhaps it would be best to switch to just including it in the main ng-packagr build?

Here are things I found when looking through and testing out the code:

  • The single-spa-angular Parcel component isn't being built with ng-packagr
  • When I test out single-spa-angular locally, I run into the following error:
    image

joeldenning
joeldenning commented Apr 17, 2020
View reviewed changes
tsconfig.parcel.json Outdated Show resolved Hide resolved
joeldenning
joeldenning commented Apr 18, 2020
View reviewed changes
Copy link
Member Author

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joeldenning joeldenning merged commit c5c051e into master Apr 18, 2020
@joeldenning joeldenning deleted the parcel-fixes branch April 18, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturovt arturovt Awaiting requested review from arturovt

Assignees
No one assigned
Labels
ready to release type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeldenning @arturovt