Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revive schematics functionality #231

Merged
merged 2 commits into from Jun 25, 2020

Conversation

Den-dp
Copy link

@Den-dp Den-dp commented Jun 24, 2020

Include ignored builders.json and schematics.json files into package so ng add
will stop complain about missing collections.

Closes: #226

Include ignored builders.json and schematics.json files into package so ng add
will stop complain about missing collections.

Closes: single-spa#226
@Den-dp
Copy link
Author

Den-dp commented Jun 24, 2020

despite the fact that this PR helps with ng add, I just found another problem while running spa build

ENOENT: no such file or directory, open 'C:\dev\rep\testapp\node_modules\single-spa-angular\src\builders\browser\schema.json'
Error: ENOENT: no such file or directory, open 'C:\dev\rep\testapp\node_modules\single-spa-angular\src\builders\browser\schema.json'
    at Object.openSync (fs.js:440:3)
    at Object.readFileSync (fs.js:342:35)
    at Observable._subscribe (C:\dev\rep\testapp\node_modules\@angular\cli\node_modules\@angular-devkit\core\node\host.js:171:35)
    at Observable._trySubscribe (C:\dev\rep\testapp\node_modules\@angular\cli\node_modules\rxjs\internal\Observable.js:44:25)
    at Observable.subscribe (C:\dev\rep\testapp\node_modules\@angular\cli\node_modules\rxjs\internal\Observable.js:30:22)
    at MapOperator.call (C:\dev\rep\testapp\node_modules\@angular-devkit\architect\node_modules\rxjs\internal\operators\map.js:32:23)
    at Observable.subscribe (C:\dev\rep\testapp\node_modules\@angular\cli\node_modules\rxjs\internal\Observable.js:25:22)

It looks like we should add all schema.json files from src/. Will try it right now and add to this PR if it will help

@Den-dp
Copy link
Author

Den-dp commented Jun 24, 2020

Changing "src/schematics/ng-add/schema.json" -> "src/**/schema.json" helped

@joeldenning joeldenning merged commit c041c32 into single-spa:3.x Jun 25, 2020
@joeldenning
Copy link
Member

Released in https://github.com/single-spa/single-spa-angular/releases/tag/v3.5.3

@Den-dp Den-dp deleted the fix/include-schematics-in-package branch December 6, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants