Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Nrwl Nx workspace #293

Merged
merged 1 commit into from
Nov 3, 2020
Merged

feat: support Nrwl Nx workspace #293

merged 1 commit into from
Nov 3, 2020

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Nov 3, 2020

No description provided.

@arturovt arturovt marked this pull request as ready for review November 3, 2020 12:10
@arturovt arturovt added this to In progress in single-spa-angular Nov 3, 2020
joeldenning
joeldenning approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes here, but this looks good to me. Excited for an easier workflow with nx!

@arturovt arturovt merged commit e582c4a into single-spa:master Nov 3, 2020
@arturovt arturovt deleted the nrwl-nx branch November 3, 2020 18:32
@arturovt arturovt moved this from In progress to Done in single-spa-angular Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
single-spa-angular
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arturovt @joeldenning