Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide umdId for the single-spa-angular/internals #299

Merged
merged 1 commit into from Nov 9, 2020
Merged

fix: provide umdId for the single-spa-angular/internals #299

merged 1 commit into from Nov 9, 2020

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Nov 8, 2020

Closes #204

This provides a valid UMD id for the internals package. Since single-spa-angular tries to resolve the single-spa-angular/internals package using single-spa-angular-internals id, but ng-packagr generated single-spa-angular/internals UMD id.

joeldenning
joeldenning approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@joeldenning joeldenning merged commit 34e43b5 into single-spa:master Nov 9, 2020
@arturovt arturovt deleted the fix-umd branch November 9, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application not working with webpack externals
2 participants
@arturovt @joeldenning