Registering applications using a configuration object revision 1 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
reviewed
Jan 5, 2018
| @@ -80,6 +81,7 @@ describe("SystemJS loader :", () => { | |||
| happyUnload(); | |||
| invalidUnload(); | |||
| lifecyleProps(); | |||
| registerWithObject(); | |||
There was a problem hiding this comment.
We've got some tabs vs spaces stuff here -- maybe we should follow this pr up with a pr that converts all the tabs to spaces?
|
|
||
| export default function() { | ||
| describe(`register-with-object`, () => { | ||
| beforeAll(() => { |
There was a problem hiding this comment.
Mixture of tabs and spaces.
We should convert everything to spaces across the whole project, but if that isn't done in this pr we should at least not mix tabs and spaces in new code.
There was a problem hiding this comment.
Fixed. It's all spaces now.
TheMcMurder
added a commit
that referenced
this pull request
Jan 9, 2018
* Registering applications using a configuration object revision 1 * Spaces
TheMcMurder
added a commit
that referenced
this pull request
Jan 11, 2018
* Pr/new api (#137) * Brute force removing references to children from the application * Renaming to registerApplication * registerApplication * Brute force updating documentation * Fixing tests that were using `unloadChildApplication` * appName not childAppName * Updating docs * Updating docs * updating tests * Updating test variable names * Fixing all remaining refs to child-apps/child apps/child app * Pr/decrecation notice (#138) * Adding back old API's along with deprecation notice * Adding documentation marking the api's as deprecated * Hahaha whoops. * Pr/single spa config (#139) * actually upping the version number * Updating documentation for root-application to be called single-spa-config * Updating Root Application file to call out the name change explicitly and why * Completing documentation changes * A few more documentation changes * Found one more reference I missed * Global find replace failed me here. Fixing a bunch of small grammar and sentence issues. * Registering applications using a configuration object revision 1 (#143) * Registering applications using a configuration object revision 1 * Spaces * Pr/tabs spaces (#144) * Turning all tabs into spaces * Fixing duplicate import error * spaces instead of tabs for all .spec files * tabs to spaces in additional files I missed (#146) * Pr/adding documentation on using applications for registration (#152) * small change here, the docs were ignoring the second argument * Adding an explanation of using the application as the second argument. - Putting existing section on the loading function as a sub section of the new section on either loading function or Application - Adding example of inline application definition. * Fixing capitalization on files * More tiny capitalization changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.