Adding detail to object, including originalEvent, to custom events. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
commented
Dec 29, 2018
| } | ||
| } | ||
| window.dispatchEvent(new CustomEvent("single-spa:before-routing-event", myCE)); | ||
| window.dispatchEvent(new CustomEvent("single-spa:before-routing-event", getCustomEventDetail())); |
There was a problem hiding this comment.
This is technically a breaking change. For the before-routing-event, we used to be providing an event object as the custom event detail but we no longer are.
However, that was an undocumented feature and one that I don't think anyone actually uses. It was originally put in to support some stuff in single-spa-canopy, but not even that project uses it anymore.
| }, | ||
| "browserslist": [ |
There was a problem hiding this comment.
A somewhat random stab at what browsers we should support with single-spa. Before this PR, we were basically just doing preset-es2015 (since that's mostly the default for preset-env)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is a pending feature for single-spa-angular that needs the
single-spa:routing-eventCustomEvent to tell it whether the routing event was caused by a popstate event, a hashchange event, or neither.