Add module entry on package.json #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This entry helps out with rollup bundling. Since the transpiled library located at "lib/single-spa.js" is in CommonJS format, rollup (more precisely rollup-plugin-commonjs plugin) has trouble finding the exports, unless they are named on the namedExports configuration. If instead we set a module name on the package.json, this change solves this specific issue.
Added a module entry on package.json
|
I believe the tests failed just due to the brittleness of our testing integration at the moment. I think this looks good to me. @joeldenning @TheMcMurder any objections? |
This was referenced Feb 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entry helps out with rollup bundling. Since the transpiled library located at "lib/single-spa.js" is in CommonJS format, rollup (more precisely rollup-plugin-commonjs plugin) has trouble finding the exports, unless they are named on the namedExports configuration.
If instead we set a module name on the package.json, this change solves this specific issue.