Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace tab to spaces #376

Merged
merged 1 commit into from
Nov 23, 2019
Merged

chore: replace tab to spaces #376

merged 1 commit into from
Nov 23, 2019

Conversation

kuitos
Copy link
Contributor

@kuitos kuitos commented Nov 22, 2019 •
edited

This change is Reviewable

@ghost
Copy link

ghost commented Nov 22, 2019 •
edited by ghost

DeepCode Report (#733a31)

DeepCode analyzed this pull request.
There are no new issues.

frehner
frehner reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we wanted something like this, we would probably go with prettier instead

@kuitos kuitos changed the title feat: add editorconfig chore: replace tab to spaces Nov 22, 2019
@kuitos
Copy link
Contributor Author

kuitos commented Nov 22, 2019

I think if we wanted something like this, we would probably go with prettier instead

well, had changed the purpose of pr

@frehner
Copy link
Member

frehner commented Nov 22, 2019

Ok.

I'm actually still open to the idea of adding prettier as well, to be clear.

@frehner frehner merged commit f585be8 into single-spa:master Nov 23, 2019
kuitos added a commit to kuitos/single-spa that referenced this pull request Feb 23, 2020
@kuitos
chore: replace tab to spaces (single-spa#376)
e7b16e5
@kuitos kuitos deleted the feat/editorconfig branch April 9, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frehner frehner frehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuitos @frehner