Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running tests on windows #492

Merged
merged 2 commits into from Mar 20, 2020
Merged

Fix running tests on windows #492

merged 2 commits into from Mar 20, 2020

Conversation

krzyswiatkowski
Copy link
Contributor

@krzyswiatkowski krzyswiatkowski commented Mar 20, 2020 •
edited

Resolves: #491

  • Added cross-env package as devDependency
  • Modified test command

@krzyswiatkowski krzyswiatkowski mentioned this pull request Mar 20, 2020
Closed
joeldenning
joeldenning approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your bug report and pull request. This looks good to me

@joeldenning joeldenning merged commit 7410ce6 into single-spa:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krzyswiatkowski @joeldenning