ci: add writ tests #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvetere
requested changes
Jul 27, 2022
examples/rust/dates/Makefile
Outdated
| @@ -14,11 +14,12 @@ wasm: | |||
| cargo wasi build --lib $(RELFLAGS) | |||
|
|
|||
| .PHONY: test | |||
| test: debug | |||
| test: wasm | |||
There was a problem hiding this comment.
Similar to the above comment, but opposite. Changing this dependency to "wasm" implies the target will always be built in debug mode because theRELFLAGS variable won't be set.
There was a problem hiding this comment.
hrm. I think I'm going to remove any dependency then. The thing I was trying to refactor is that when it depends on debug, it builds debug even after having just built a release (which is the module I actually want to test).
examples/cpp/power/Makefile
Outdated
| @@ -16,7 +16,7 @@ power.wasm: gen | |||
| power.c | |||
|
|
|||
| .PHONY: test | |||
| test: debug | |||
| test: power.wasm | |||
There was a problem hiding this comment.
Changing this dependency to power.wasm implies that the test will always be built in release mode because the DBGFLAGS variable won't be set. Perhaps we should set DBGFLAGS globally and then have the release: target clear it?
- changed make target for test to depend on a wasm module. That way we can test both release and debug in the CI. - If I spied rust unit tests, I added those to the make target. We could also consider gtests for C++ examples in the future. - only run pages when files change
pvetere
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a wasm module. That way we can test both
release and debug in the CI.
make target. We could also consider gtests
for C++ examples in the future.