Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static analysis to the pipeline of the main repos #51

Closed
andre-senna opened this issue Jul 11, 2024 · 0 comments · Fixed by singnet/das-atom-db#160, singnet/das-query-engine#278 or singnet/das-serverless-functions#124
Assignees

Comments

@andre-senna
Copy link
Contributor

andre-senna commented Jul 11, 2024

  • Query engine
  • Atom DB
  • Functions

Make sure we have a make pre-commit command in all theses repos. This target is supposed to run:

(a) Unit tests
(b) Unit tests coverage check
(b) Integration tests
(c) Static analysis

Each of these checks is supposed to be executed in all repo's pipeline to check every newly changed PR. PRs can be allowed to merge even if some of these checks fail.

Each check should be implemented separately in the pipeline (as 4 different checks) but we should have an action to call all of them at once. In a future task (#52), we'll use this action to run periodic (e.g. daily) checks on our repos, reporting problems in our internal Mattermost channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment