Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines visibility in dark mode (Fix Issue #207) #231

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

18Venus
Copy link
Contributor

@18Venus 18Venus commented May 29, 2024

Issue Title: Visibility Issue in Dark Mode

resolve issue: #207

Type of change ☑️

What sort of change have you made:
I have fixed the CSS of the guidelines box so that the text is clearly visible in both light and dark mode.

  • Bug fix (non-breaking change which fixes an issue)
  • Code style update (formatting, local variables)

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️

Describe how have you verified the changes made.

I have run the code and here are the screenshots of the changes:

Light Mode(No change):
light-mode

Dark Mode(changed):
dark-mode

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 3:18pm
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 3:18pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@18Venus 18Venus changed the title Guidelines visibility in dark mode Guidelines visibility in dark mode (Fix Issue #207) May 30, 2024
0xabdulkhalid

This comment was marked as duplicate.

tailwind.config.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@0xabdulkhalid 0xabdulkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

Now this PR is ready to be merged! @singodiyashubham87 🚀

@0xabdulkhalid 0xabdulkhalid added bug Something isn't working gssoc level1 labels May 31, 2024
@singodiyashubham87 singodiyashubham87 merged commit 0b62d06 into singodiyashubham87:main Jun 2, 2024
4 checks passed
@singodiyashubham87
Copy link
Owner

@18Venus Well Done, Keep contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants