-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines visibility in dark mode (Fix Issue #207) #231
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👀
Now this PR is ready to be merged! @singodiyashubham87 🚀
@18Venus Well Done, Keep contributing :) |
Issue Title: Visibility Issue in Dark Mode
resolve issue: #207
Type of change ☑️
What sort of change have you made:
I have fixed the CSS of the guidelines box so that the text is clearly visible in both light and dark mode.
Checklist: ☑️
How Has This Been Tested? ⚙️
Describe how have you verified the changes made.
I have run the code and here are the screenshots of the changes:
Light Mode(No change):
![light-mode](https://private-user-images.githubusercontent.com/149051659/334890735-be5d01e3-87fa-42bd-8f04-b403e7bd29ea.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNjc3NTQsIm5iZiI6MTcyMjI2NzQ1NCwicGF0aCI6Ii8xNDkwNTE2NTkvMzM0ODkwNzM1LWJlNWQwMWUzLTg3ZmEtNDJiZC04ZjA0LWI0MDNlN2JkMjllYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQxNTM3MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NDdiY2IzMDEzMzFiOWY2ODU2N2Q0YjhiODA0MmI4NTliMmRkOTE0YThmNDQxODczMDU5N2FlMGY3NGUwMmE0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.gjczpJJ7lrtPNgbzcGJaJ-84XzEEwTiQ02ikHxYb3d8)
Dark Mode(changed):
![dark-mode](https://private-user-images.githubusercontent.com/149051659/334890986-689c9eee-bcb2-4843-b9ec-c40ad8010be0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNjc3NTQsIm5iZiI6MTcyMjI2NzQ1NCwicGF0aCI6Ii8xNDkwNTE2NTkvMzM0ODkwOTg2LTY4OWM5ZWVlLWJjYjItNDg0My1iOWVjLWM0MGFkODAxMGJlMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOVQxNTM3MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lOWQ1OTgxMzNmMTE5NjA1YTJmNTE4YWVlOTVmODA5MDMyOGE0NDY5ODQ1MzNlNDkxN2M4ZmY4NWE2MzJiNDU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.JYOoN3c9f0WNkRYZ74LvC5kNdb6luNMBKV7PLCyGvKM)