fix: validate nie with x fails

singuerinc · May 22, 2018 · f2773cf · f2773cf
1 parent 08a3446
commit f2773cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/dni.test.js b/dni.test.js
@@ -32,6 +32,10 @@ describe('dni', () => {
 
   describe('valid', () => {
     describe('nif', () => {
+      it('should validate x9464186p', () => {
+        assert.equal(isValid('x9464186p'), true);
+      });
+
       it('should validate 55799910R', () => {
         assert.equal(isValid('55799910R'), true);
       });

diff --git a/index.js b/index.js
@@ -29,7 +29,7 @@ const isValid = value => {
 
   if (!value && !_isNIF(dni) && !_isNIE(dni)) return false;
 
-  const f = { x: 0, y: 1, z: 2 }[dni[0]] || dni[0];
+  const f = { x: '0', y: '1', z: '2' }[dni[0]] || dni[0];
   const dni_1_to_7 = dni.substr(1, 7);
   const i = +(f + dni_1_to_7) % 23;
 

diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "main": "index.min.js",
   "license": "MIT",
   "author": "Nahuel Scotti <nahuel.scotti@gmail.com> (https://www.singuerinc.com)",
-  "repository": "singuerinc/better-dni.git",
+  "repository": "singuerinc/better-dni",
   "engines": {
     "node": ">=6"
   },