-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): support float mul interval #3641
Conversation
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
LGTM except that some style mismatch, e.g.,
Just add / remove spaces to match the style, and add |
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
The previous implementation for |
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Codecov Report
@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 74.39% 74.37% -0.02%
==========================================
Files 776 776
Lines 110134 110163 +29
==========================================
+ Hits 81931 81935 +4
- Misses 28203 28228 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* feat(expr): support float mul interval Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support float mul interval Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support float mul interval Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support float mul interval Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): Modify the Display implementation of IntervalUnit Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support float mul interval Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): Modify the Display implementation of IntervalUnit Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): Modify the Display implementation of IntervalUnit Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy wyf000219@126.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
support these expr
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
#924 #3341