Gailin/fix consumed sign bug #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add neg check to output_to_results * add rate columns to negative check * make negative check not error on small (small run has data issues leading to negative, caused by using subset of data)
grgmiller
approved these changes
Sep 7, 2022
.gitignore
Outdated
| @@ -14,6 +14,9 @@ notebooks/.ipynb_checkpoints | |||
| notebooks/*/.ipynb_checkpoints | |||
| .hypothesis/ | |||
|
|
|||
| # Editor settings | |||
| .vscode/* | |||
There was a problem hiding this comment.
This seems to duplicate line 24 (although I hadn't included the wildcard) - maybe we should just delete line 24
| self.results[ba]["net_consumed_mwh"] = ( | ||
| self.generation[ba] + self.eia930.df[KEYS["E"]["TI"] % ba] | ||
| )[self.generation.index] | ||
| if ba in BA_930_INCONSISTENCY: |
There was a problem hiding this comment.
Great, I like how we only use demand for these BAs that have issues.
| @@ -77,13 +92,18 @@ def output_intermediate_data(df, file_name, path_prefix, year, skip_outputs): | |||
|
|
|||
|
|
|||
| def output_to_results(df, file_name, subfolder, path_prefix, skip_outputs): | |||
| # Always check columns that should not be negative. | |||
| small = "small" in path_prefix | |||
There was a problem hiding this comment.
This is a clever way to do this without passing args.small to the function!
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214 , see issue for more commentary
write_power_sector_resultsnet_consumed_mwhnet_consumed_mwhfor BAs with inconsistencies between EIA-930 interchange and ournet_generation_mwh, because these inconsistencies prevent calculation of a reasonablenet_consumed_mwhoutput_to_resultsto guarantee that all result files must pass validation check