-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates python version in pyproject.toml and removes requirements.txt #344
Updates python version in pyproject.toml and removes requirements.txt #344
Conversation
tested that it was able to be installed in Greta |
Right now the target branch is |
If we update the version, this also needs to be updated in the |
why are we using both CITATION.cff and pyproject.toml to specify the version? |
I think they serve different purposes. the citation file is to help with the citability for academic purposes, so the version number is specified there as well. https://citation-file-format.github.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Purpose
This change:
requirements.txt
file, since we have 3 other dependency management files in this repo (correct me if we want that, but it wasn't referenced in the README at all)What the code is doing
updating the python version in pyproject.toml
Testing
I will test this change by trying to install it in Greta
Where to look
n/a
Usage Example/Visuals
n/a
Review estimate
5 minutes
Future work
none for this change
Checklist
black