-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access a specific GWP when calculating CO2 mass equivalent value #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested. It would be helpful if you could test passing the following to see what it returns:
- 2022 (should return AR6 numbers)
- "AR4" (should return AR4)
- Test several variations of AR5 with and without the CC feedback.
In the last version of the code where I have a print of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben, a few small additional documentation changes requested, but otherwise good to go.
Looks good to me! Should be ready to merge. |
Purpose
Allow to calculate a CO2 mass equivalent value using a Global Warming Potential (GWP) value published in any available IPCC's assessment report (AR).
What the code is doing
Modify the
calculate_co2e_mass
function such that its second parameter can be used to fetch not only the most recent AR that was available in the given year as done previously but also to directly fetch the AR.Testing
Tested manually
Where to look
In the
oge.emissions
moduleUsage Example/Visuals
Review estimate
2min
Future work
N/A
Checklist
black