-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using docker container from quay.io #1
Conversation
Have you tested this? Typically a container with Singularity has permissions or other issues because we aren’t running it privileged, hence the strategy here to install natively. |
yes, but only with simple command line applications, including this one now. $ export GITHUB_TOKEN=...
$ curl -L -H "Authorization: token $GITHUB_TOKEN" \
https://api.github.com/repos/kiwiroy/github-ci/actions/artifacts/18516234/zip > container.zip
$ unzip container.zip
$ singularity run container.sif
Hold me closer... tiny container :D |
I like this approach, and I have a proposal for you - I do think this approach would work for simple builds, but there is likely to be some issue depending on the build. What do you think about creating a separate workflow - called .github/workflows/container.yml (or something intuitive like that) and then providing this option? Then in the README, clearly state that go.yml is intended to show a native install, and container.yml uses a pre-built container on quay.io. Then the user can select whichever recipe is best fit for their use case. |
Sounds good.
|
+1 to make the go.yaml more clearly named! I would even go further and call it |
f3a487b
to
e6892a9
Compare
e6892a9
to
662868a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Are you finished up @kiwiroy and this is ready for merge?
Thanks. I'd consider it ready for merging. |
Thank you @kiwiroy ! I think this greatly improves the repository with the additional example. |
Using the prebuilt container seems like a good idea in terms of efficiency and simplicity of the yaml definition. Are there any drawbacks?