Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing entrypoint accounting for WORKDIR #115

Merged
merged 3 commits into from May 28, 2019
Merged

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented May 28, 2019

This will fix #114, a quick fix so that the last working directory is honored. For the recipe here, that means that we cd to /code first (shown below).

...
# EXPOSE 3031
%environment
export PYTHONUNBUFFERED=1
%runscript
cd /code
exec /bin/bash "$@"

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

vsoch added 2 commits May 28, 2019 09:25
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
spython/main/parse/docker.py Outdated Show resolved Hide resolved
spython/main/parse/converters.py Outdated Show resolved Hide resolved
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented May 28, 2019

@Flamefire I know we need tests, and I'd like to triage these fixes so we can get to the larger fixes anticipated. Let me know if this looks ready (I think so).

@vsoch vsoch merged commit 52fc5d2 into master May 28, 2019
@vsoch vsoch deleted the add/workdir-to-runscript branch May 28, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CD to WORKDIR is missing in singularity runscript
2 participants