Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring that we dont support multistage builds #164

Merged
merged 1 commit into from May 29, 2020
Merged

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented May 28, 2020

This issue will close #163, specifically warning the user that multistage builds are not supported, and ensuring that warnings are one per line. This is now the output given the changes - the warnings are moved to one line each, and the --from lines with copy are not supported.

$ spython recipe Dockerfile > testrecipe.def
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_PROJ_INSTALL_PREFIX=/usr/local on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_BASE_IMAGE=ubuntu:20.04 on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_KEA_VERSION=1.4.13 on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_MONGO_C_DRIVER_VERSION=1.16.2 on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_MONGOCXX_VERSION=3.5.0 on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_TILEDB_VERSION=2.0.2 on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_OPENJPEG_VERSION= on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_RSYNC_REMOTE on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_PROJ_VERSION=master on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_PROJ_INSTALL_PREFIX on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_GDAL_VERSION=master on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_GDAL_RELEASE_DATE on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_GDAL_BUILD_IS_RELEASE on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_PROJ_DATUMGRID_LATEST_LAST_MODIFIED on the host.
WARNING ARG is not supported for Singularity! Add as ENV to the container or export SINGULARITYENV_PROJ_INSTALL_PREFIX on the host.
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build_thirdparty/usr/ /usr/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build${PROJ_INSTALL_PREFIX}/share/proj/ ${PROJ_INSTALL_PREFIX}/share/proj/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build${PROJ_INSTALL_PREFIX}/include/ ${PROJ_INSTALL_PREFIX}/include/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build${PROJ_INSTALL_PREFIX}/bin/ ${PROJ_INSTALL_PREFIX}/bin/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build${PROJ_INSTALL_PREFIX}/lib/ ${PROJ_INSTALL_PREFIX}/lib/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build/usr/share/gdal/ /usr/share/gdal/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build/usr/include/ /usr/include/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build_gdal_python/usr/ /usr/
WARNING Singularity does not support multistage builds, skipping COPY --from=builder  /build_gdal_version_changing/usr/ /usr/

Signed-off-by: vsoch vsochat@stanford.edu

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented May 29, 2020

I don't think the person I helped is going to review this :/

But the changes are simple enough that I think it's worth merging at least for now, I'm going to start working on a parser that could support the multistage build after that.

@vsoch vsoch merged commit b012900 into master May 29, 2020
@vsoch vsoch deleted the add/check-from-line branch May 29, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singularity doesn't support multistage builds
1 participant