Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on GitHub #185

Merged
merged 6 commits into from Oct 2, 2021
Merged

Test on GitHub #185

merged 6 commits into from Oct 2, 2021

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Oct 2, 2021

This extends #183 to also remove the stop all command, and name instances based on the python version (and stop by name only).

@vsoch
Copy link
Member Author

vsoch commented Oct 2, 2021

@MarDiehl it looks like I fixed the issue - I no longer see the error about not having instances! So we can merge here - I'm going to keep CircleCI active for a bit just for a sanity check. This PR includes all your commits so you'll get credit for the work, and after this commit is added you can integrate into your other PR to remove all those warnings!

@vsoch vsoch merged commit 4f583e6 into master Oct 2, 2021
@vsoch vsoch deleted the test-on-github branch October 2, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants