removing checks for versions across all files and 2.x image commands … #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import, export the reason being so we can easily support apptainer and singularityce installs, which both provide an executable singularity but with different versions! Also, people should not be using the 2.x command groups at this point because there are too many security issues. We can support this in some small way by not making it easy/possible to do here, unless they want to install an older version. This will fix #190 Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
@georgiastuart do you want to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…import, export
the reason being so we can easily support apptainer and singularityce installs,
which both provide an executable singularity but with different versions! Also,
people should not be using the 2.x command groups at this point because there are too
many security issues. We can support this in some small way by not making it easy/possible
to do here, unless they want to install an older version. This will fix #190
Signed-off-by: vsoch vsoch@users.noreply.github.com