Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link in README #3

Open
fenz opened this issue Apr 24, 2021 · 2 comments
Open

Wrong link in README #3

fenz opened this issue Apr 24, 2021 · 2 comments

Comments

@fenz
Copy link

fenz commented Apr 24, 2021

If I got the rational behind the image tags definition, I guess last link in the README (https://github.com/singularityhub/singularity-deploy#1-write-your-singularity-recipes) should be:

instead of
@vsoch
Copy link
Member

vsoch commented Apr 24, 2021

Yes that looks correct.

@fenz
Copy link
Author

fenz commented Apr 25, 2021

I guess also here: https://github.com/singularityhub/singularity-deploy#2-update-the-version-file
we have each of "deploy," "latest," and "salad" released under tag 0.0.1
It should probably be "pokemon" instead of "deploy".
I add this here since I guess it can be done in the same README update.

wood-chris added a commit to wood-chris/singularity-deploy that referenced this issue Aug 3, 2021
@wood-chris
Correcting typo in docs (addressing issue singularityhub#3)
3bca3aa
vsoch added a commit that referenced this issue Aug 3, 2021
@wood-chris @vsoch
Correcting typo in docs (addressing issue #3) (#8)
ff22b0d 
* Correcting typo in docs (addressing issue #3)
* fixing typo latest -> salad

Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsoch @fenz