Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote registries on self-hosted gitlab instances #630

Closed
phue opened this issue Feb 14, 2023 · 3 comments · Fixed by #631
Closed

Support remote registries on self-hosted gitlab instances #630

phue opened this issue Feb 14, 2023 · 3 comments · Fixed by #631

Comments

@phue
Copy link
Contributor

phue commented Feb 14, 2023

Hi @vsoch,

First of all, thanks for this great tool!
I'm trying to deploy a custom registry on a self-hosted Gitlab instance and use it on our HPC system.
However, it seems that constructing the url to gitlab pages currently works with the gitlab.io domain only.

return "https://%s.%s.io/%s/library.json" % (

In my specific case, I would need this pattern: https://%s.pages.%s.rlp.net/%s/library.json instead.
Would it be possible to add a config option for a custom url?

@vsoch
Copy link
Member

vsoch commented Feb 14, 2023

Oh we could definitely handle that! Perhaps we should have a registry options with the url format string there?

@vsoch
Copy link
Member

vsoch commented Feb 14, 2023

But perhaps it could be derived from the source_url instead? Can you show me your source URL?

phue added a commit to imbforge/singularity-hpc that referenced this issue Feb 14, 2023
@phue
Copy link
Contributor Author

phue commented Feb 14, 2023

But perhaps it could be derived from the source_url instead? Can you show me your source URL?

I didn't think of that, that should work.

Essentially, the source_url for selfhosted instances is gitlab.example.com/<username>/<reponame> which gets served at <username>.pages.gitlab.example.com/<reponame> (see https://docs.gitlab.com/ee/administration/pages/#prerequisites)

The attached pull request should do the trick, while keeping the functionality for gitlab.com and github.com

vsoch pushed a commit that referenced this issue Feb 15, 2023
* support parsing repository urls that require auth
* add support for self-hosted gitlab instances
* be more explicit when parsing url
* bump version to 0.1.19

closes #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants