Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/example google cloud storage #638

Merged
merged 4 commits into from
May 4, 2023
Merged

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Apr 1, 2023

This will close #605

Note that the GCP bucket is not a registry, it's a cache for all containers / module files to be mounted somewhere.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch vsoch mentioned this pull request Apr 1, 2023
@evalanguaria
Copy link

@vsoch I am sorry for the late reply, was swamped with work and couldnt test this. I have now tested it and was wondering if it was possible to put the modules and containers in their own folders so that it is easier to provide them in the settings.yml file. If this is already taking too much of your time, you can close it and I can try and incorporate the changes I need. Thank you.

@vsoch
Copy link
Member Author

vsoch commented May 4, 2023

@evalanguaria that should be an easy change - before you run the script, just edit your shpc settings.yaml config and ensure the containers/modules are installed to different locations. You will then need to update the script to handle the change in location (instead of just root you will have two!)

This is the simplest implementation that I would like to provide for the example for other users, so I think it's best that if you'd like it customized you are free to do something else.

@evalanguaria
Copy link

@vsoch yes that makes sense. I will make the necessary modifications. Thanks a lot again for everything.

@vsoch vsoch merged commit f89a16d into main May 4, 2023
11 checks passed
@vsoch vsoch deleted the add/example-google-cloud-storage branch May 4, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP buckets as registry
2 participants