fix: podman inspect typo #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The podman inspect script (generated as a wrapper script) accidentally has singularity hard coded instead of the container.command template variable. This will fix that. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
thanks @vsoch this is a great tool and i am glad this works with podman which gives us an option to test this out on Perlmutter. |
|
@shahzebsiddiqui do you have any other issues / requests before we merge and release (if so I'd like to get them into the PR here, but if not happy to get this released soon!) |
|
i am good for now. I will be testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The podman inspect script (generated as a wrapper script) accidentally has singularity hard coded instead of the container.command template variable. This will fix that.
This will close #641 - took all of two seconds to do!
And @shahzebsiddiqui I'm really glad you are testing podman! I think most of the work has been around Singularity, but podman is also important for HPC. Definitely let us know of any other bugs that you find!