update shpc show output stream and support --limit #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2023
| "--limit", | ||
| help="set a limit for the number to show", | ||
| default=None, | ||
| type=int, |
There was a problem hiding this comment.
i guess you may want to enforce to positive number and not just any number to avoid passing value like --limit 0 or negative value
There was a problem hiding this comment.
This actually isn’t needed because if the user sets a hairbrained limit like that, the loop should just quit immediately.
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
update/output-stream
branch
from
1dcc094
to
e3cd198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #646 and close #645