Adding wrapper_base to allowed_envars #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theklaloizou
changed the title
|
This looks good! Since you are new I won't ask for extra work (e.g., release stuffs mostly) - we can do a release for this the next time around. I think @marcodelapierre is going to do some work in a few weeks so it will be grouped with that. Thanks @theklaloizou ! |
vsoch
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the addition of wrapper_base option in settings.yml file when using an environment variable in the wrapper_base path the variable is not expanded correctly.
This is a PR to fix this issue by just adding wrapper_base in the allowed_envars.