Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug that the registry api base needs to end with api #196

Merged
merged 1 commit into from May 10, 2019

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented May 10, 2019

This will fix #195 , specifically the collection permission check URL was (incorrectly) using the upload url, which expects (as the error suggests) multipart form data in the way of the container binary. The fix was to restore the check that the client url ends with api.

After removing all previous versions:

$ pip uninstall sregistry

(do that until it says not installed)

You can clone this branch, and install to test:

git clone -b fix/bug-api-base https;//www.github.com/singularityhub/sregistry-cli
cd sregistry-cli
python setup.py install
SREGISTRY_CLIENT=registry sregistry push --name mycollection/salad:latest salad_latest.sif

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch vsoch merged commit a94a4f3 into master May 10, 2019
@vsoch vsoch deleted the fix/bug-api-base branch May 10, 2019 18:15
@vsoch
Copy link
Member Author

vsoch commented May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push returning 415 Unsupported Media Type
1 participant