Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label value not decoded #27

Closed
wa0x6e opened this issue Sep 1, 2023 · 0 comments
Closed

Label value not decoded #27

wa0x6e opened this issue Sep 1, 2023 · 0 comments

Comments

@wa0x6e
Copy link

wa0x6e commented Sep 1, 2023

When pushing metrics, most libraries do encode the labels value before sending them, following the specs by the pushgateway (https://github.com/prometheus/pushgateway/blob/master/README.md#url)

So sending metrics{instance="localhost:80"} 1 should return metrics{instance="localhost:80"} 1 on the gateway side.

The issue I have with gravel-gateway is that the labels value are not being decoded, and the gateway display instead:

metrics{instance="localhost%3A80"} 1

Fix will be to decode all labels value before any processing

sinkingpoint added a commit that referenced this issue Nov 17, 2023
This is a bit of a bug fix release that solves:

- #27
- #29
- sinkingpoint/openmetrics-parser#2

Signed-off-by: sinkingpoint <colin@quirl.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant