Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React FeatureAppLoader: Rename nodeSrc prop to serverSrc #209

Closed
clebert opened this issue Dec 30, 2018 · 0 comments
Closed

React FeatureAppLoader: Rename nodeSrc prop to serverSrc #209

clebert opened this issue Dec 30, 2018 · 0 comments
Milestone
Backlog

Comments

@clebert
Copy link
Member

clebert commented Dec 30, 2018 •
edited
Loading

The React FeatureAppLoader does not care if it is rendered within Node.js or another server-side environment. The documentation also talks about "server" in general and not "Node.js" in particular.
@clebert clebert changed the title React FeatureAppLoader: Rename nodeSrc to serverSrc React FeatureAppLoader: Rename nodeSrc prop to serverSrc Dec 30, 2018
@clebert clebert added this to the Backlog milestone Jan 3, 2019
@fahrradflucht fahrradflucht mentioned this issue Jan 4, 2019
Merged
clebert pushed a commit that referenced this issue Jan 4, 2019
@fahrradflucht @clebert
feat(react): rename nodeSrc to serverSrc (#231)
85c65a7 
Closes #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@clebert