Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Customizable loading UI in FeatureAppLoader/FeatureAppContainer #296

Closed
fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #557
Closed

React: Customizable loading UI in FeatureAppLoader/FeatureAppContainer #296

fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #557
Labels
story
Milestone
Backlog

Comments

@fahrradflucht
Copy link
Member

fahrradflucht commented Jan 24, 2019 •
edited by unstubbable
Loading

  • the integrator must be able to define a loading UI for a FeatureAppLoader/FeatureAppContainer
  • as the default behavior the loading UI should be removed once the Feature App has been created
  • optionally, a Feature App must be able to control when the loading UI is removed
@fahrradflucht fahrradflucht added this to the Backlog milestone Jan 24, 2019
@clebert clebert changed the title Customizable loading UI in FeatureAppLoader Customizable loading UI in FeatureAppLoader/FeatureAppContainer Jan 24, 2019
@clebert clebert changed the title Customizable loading UI in FeatureAppLoader/FeatureAppContainer React: Customizable loading UI in FeatureAppLoader/FeatureAppContainer Mar 1, 2019
@clebert clebert modified the milestones: Backlog, Mathis Mar 4, 2019
@clebert clebert modified the milestones: Wiehl Change, Backlog Mar 22, 2019
@clebert clebert added wontfix This will not be worked on and removed refinement needed story labels Aug 5, 2019
@clebert clebert closed this as completed Aug 5, 2019
@unstubbable unstubbable reopened this Sep 27, 2019
@unstubbable unstubbable added refinement needed story and removed wontfix This will not be worked on labels Sep 27, 2019
@unstubbable unstubbable self-assigned this Sep 27, 2019
remmycat pushed a commit that referenced this issue Feb 19, 2020
@unstubbable @remmycat
feat(react): allow custom feature app rendering
5f85c5a 
This deprecates the `renderError` prop.

fixes #296
fixes #295
remmycat added a commit that referenced this issue Feb 19, 2020
@remmycat
feat(react): allow custom feature app rendering
e574484 
This deprecates the `renderError` prop.

fixes #296
fixes #295
@remmycat remmycat mentioned this issue Feb 19, 2020
Merged
unstubbable pushed a commit that referenced this issue Feb 19, 2020
@remmycat
feat(react): allow custom feature app rendering (#557)
03a967a 
This deprecates the `renderError` prop.

fixes #296
fixes #295
@unstubbable unstubbable removed their assignment Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Loading UI feature-hub/feature-hub
3 participants
@clebert @unstubbable @fahrradflucht