Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce @feature-hub/react package #30

Closed
clebert opened this issue Nov 23, 2018 · 2 comments · Fixed by #31
Closed

Introduce @feature-hub/react package #30

clebert opened this issue Nov 23, 2018 · 2 comments · Fixed by #31
Assignees
@clebert
Milestone
Going public

Comments

@clebert
Copy link
Member

clebert commented Nov 23, 2018 •
edited
Loading

We should offer a React package. This includes both React components and the React Node.js integrator. This will replace the existing React packages.
@clebert clebert added this to the Going public milestone Nov 23, 2018
@unstubbable
Copy link
Member

Good idea, a context provider/consumer should probably also be part of that package.

@clebert
Copy link
Member Author

clebert commented Nov 23, 2018

Yes, but that could mean that we might need to support ES modules again because of code splitting.

@clebert clebert changed the title Introduce react-integrator package Introduce react package Nov 23, 2018
@clebert clebert assigned clebert and unassigned unstubbable Nov 23, 2018
clebert added a commit that referenced this issue Nov 23, 2018
@clebert
feat(react): introduce react package, closes #30
d6bb338
@clebert clebert changed the title Introduce react package Introduce @feature-hub/react package Nov 24, 2018
@clebert clebert changed the title Introduce @feature-hub/react package Introduce @feature-hub/react-components package Nov 24, 2018
@clebert clebert changed the title Introduce @feature-hub/react-components package Introduce @feature-hub/react package Nov 26, 2018
@clebert clebert mentioned this issue Nov 26, 2018
Merged
clebert added a commit that referenced this issue Nov 26, 2018
@clebert
feat(all): merge all React packages, closes #30 (#31)
0f6fdd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clebert clebert

Labels
None yet
Projects
None yet
Milestone
Going public
Development

Successfully merging a pull request may close this issue.

feat(react): introduce react package, closes #30 feature-hub/feature-hub
2 participants
@clebert @unstubbable