feat(core): make ExternalsValidator optional for the FeatureAppManager #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahrradflucht
previously approved these changes
Feb 7, 2019
unstubbable
force-pushed
the
optional-externals-validator-feature-app-manager
branch
from
ba0d318
to
35282fc
Compare
1 task
unstubbable
force-pushed
the
optional-externals-validator-feature-app-manager
branch
from
35282fc
to
b31190e
Compare
clebert
requested changes
Feb 7, 2019
unstubbable
requested review from
clebert
and removed request for
fahrradflucht
clebert
approved these changes
Feb 7, 2019
unstubbable
force-pushed
the
optional-externals-validator-feature-app-manager
branch
from
a06cc4d
to
75c78bb
Compare
clebert
approved these changes
Feb 7, 2019
unstubbable
deleted the
optional-externals-validator-feature-app-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on updating the documentation regarding externals, @fahrradflucht and I noticed, while reading the Module Loader section, that it probably makes more sense to make the
ExternalsValidatoroptional, analogous to the optional module loader. Because only when an integrator uses the optional module loader to support loading Feature Apps via URL, it makes sense for him to also validate the externals that he provides for the separately deployed Feature Apps.Note: Making the
ExternalsValidatoroptional for theFeatureServiceRegistryas is done in a follow-up PR.