feat(core): remove ability to provide configs via FeatureServiceRegistry #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The option `featureServiceConfigs` has been removed from the options of `createFeatureHub` and from the options of the `FeatureServiceRegistry` constructor. The `env` that is passed to a Feature Service's `create` method does not include a `config` property anymore. If a Feature Service must be configured, a factory function that accepts options, and that returns a Feature Service definition, should be used instead, see @feature-hub/async-ssr-manager for an example.
unstubbable
force-pushed
the
feature-registry-no-config
branch
from
683f4b7
to
a7c4b4d
Compare
clebert
requested changes
Jun 5, 2019
clebert
approved these changes
Jun 5, 2019
stemey
pushed a commit
to stemey/feature-hub
that referenced
this pull request
Jun 7, 2019
…try (feature-hub#500) BREAKING CHANGE: The option `featureServiceConfigs` has been removed from the options of `createFeatureHub` and from the options of the `FeatureServiceRegistry` constructor. The `env` that is passed to a Feature Service's `create` method does not include a `config` property anymore. If a Feature Service must be configured, a factory function that accepts options, and that returns a Feature Service definition, should be used instead, see `@feature-hub/async-ssr-manager` for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The option
featureServiceConfigshas been removed from the options ofcreateFeatureHuband from the options of theFeatureServiceRegistryconstructor. Theenvthat is passed to a Feature Service'screatemethod does not include aconfigproperty anymore. If a Feature Service must be configured, a factory function that accepts options, and that returns a Feature Service definition, should be used instead, see@feature-hub/async-ssr-managerfor an example.Note: The
primaryConsumerUidoption of the History Service will be renamed toprimaryConsumerIdin a separate PR, since this would change the API of the@feature-hub/history-servicepackage, whereas this PR only changes the API of@feature-hub/core.