fix: runToLast should respect current time #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I would have expected the timers to bail after the max number of iterations were reached, not keep scheduling new ones until we run out of memory |
SimenB
commented
Sep 17, 2018
test/lolex-test.js
Outdated
| @@ -1222,6 +1222,22 @@ describe("lolex", function () { | |||
| assert.isTrue(spy.called); | |||
| }); | |||
|
|
|||
| it("should support clocks with start time", function () { | |||
| var startingPoint = new Date("2018-01-01").getTime(); | |||
| this.clock = lolex.createClock(startingPoint); | |||
There was a problem hiding this comment.
This is a stupidly high number (1514764800000), but if you do e.g. 200 instead the test will fail with invocations being equal to 5 instead of hanging forever. Might be a better assertion? Feel free to change it if you want 🙂
fatso83
approved these changes
Sep 17, 2018
|
Simplified the test per my comment 🙂 Would love a release of this, as I'm trying to pick up Lolex in Jest again, and this is blocking |
|
Out as 2.7.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Without the code change, the added test makes node hangs forever until it runs out of memory.
Background (Problem in detail) - optional
clock.tickexpect the argument to be how many millis it should tick. Currently, we pass it the timestamp of when it should be done ticking.https://github.com/sinonjs/lolex/blob/1278eaade7da311d203fc6c33f67f85c828a09f2/src/lolex-src.js#L723
I don't understand how no-one hit this bug for 2.5 years... It's been that way since the original implementation: #50.
Solution
Subtract the current time on the clock before calling
tick. The first thing tick does is add it back, so it knows when to stop.https://github.com/sinonjs/lolex/blob/1278eaade7da311d203fc6c33f67f85c828a09f2/src/lolex-src.js#L603
We might want a
tickTomethod? Implementation would bethis.tick(to - clock.now), so maybe not valuable.