refactor: use functionality from commons package

[mgred]

Purpose (TL;DR) - mandatory

• add @sinonjs/commons
• replace functionName method with implementation from @sinonjs/commons
• use typeOf for array identification

How to verify - mandatory

1. Check out this branch
2. npm install
3. npm test

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[coveralls]

Pull Request Test Coverage Report for Build 87

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 11 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.3%) to 82.126%

---

Files with Coverage Reduction	New Missed Lines	%
formatio.js	11	82.13%

Totals
Change from base Build 83:	-0.3%
Covered Lines:	92
Relevant Lines:	110

---

💛 - Coveralls

[mgred]

Think it would make sense to replace this condition with the isSet method from samsam and therefore created sinonjs/samsam#58 as well.

[mantoni]

👍

[mgred]

Thanks @mantoni

I will create another PR to use the isSet method which depends on the next samsam release anyways 🚀

[mantoni]

@mgred Let me know if you want me to cut releases. I don’t know if you can do them yourself?

[mgred]

Hey @mantoni I can't. Would be nice if you can get this into the wild 👍

[mroderick]

@mantoni did you make a release of this?

[mantoni]

Ah, I think I did one for samsam and I understood that there is more work coming with an additional PR before this should be released. @mgred ?

[mgred]

Yes this is realeased in sinonjs/samsam#58. The method is already in use since #23 landed, so I think we're good to go with a release.